Hello, I think that makes the API more complex than necessary.
We should keep it as simple as possible. I think that for the driver there are already some fields that are MetaData, so we should document and not extend the API. As you don't point out, for example the S7 has the ability to diagnose which functions it supports, and then inform the developer. Of course it takes time to do it. My grain of sand El vie, 15 mar 2024 a las 9:02, Christofer Dutz (<christofer.d...@c-ware.de>) escribió: > Well in that case we‘d actually have to introduce the following: > > > * IsCyclicSubscriptionSupportedForTag > * IsChangeOnValueSubscriptionSupportedForTag > * IsEventSubscriptionSupportedForTag > > And possibly the “TagAddress” counterparts. > > We’d definitely be blowing up the API that way and making it more complex > to use. > > Possibly throwing an exception when buiding a request might be a better > option. > So you use the isXYZSupported functions for general functionality support > and catch exceptions later. > > Chris > > Von: Łukasz Dywicki <l...@code-house.org> > Datum: Freitag, 15. März 2024 um 10:48 > An: dev@plc4x.apache.org <dev@plc4x.apache.org> > Betreff: Re: S7 types supporting Subscriptions > Thinking of it, maybe it would be better to extend signature of > subscription inquiry to be isSubscriptionSupported(PlcTag) ? > My motivation for this is rather basic - the BACnet stuff which is on > the way will have per-participant subscriptions. Profinet (I suppose) is > same for cyclic/acyclic subscriptions and so on. > This gives driver opportunity to make smarter decision. Obviously for > point to point connection such S7-TCP we can rely on device type > negotiated earlier, *but* spanning further, we could finally let S7-1200 > subscriptions only for MODE events. > > Cheers, > Łukasz > > On 13.03.2024 21:16, Christofer Dutz wrote: > > Changing the title …. > > > > So, I just updated the S7 driver to no longer simply report true on > “isSubscriptionSupported()” and it now only reports “true”, if it’s a > S7-300 or S7-400. > > If there is more, that needs to be enabled in order to support > subscriptions on such a device, it would be cool, if we could detect that > during the connection process and report accordingly. > > > > Chris > > > > > > Von: Cesar Garcia <cesar.gar...@ceos.com.ve> > > Datum: Mittwoch, 13. März 2024 um 21:12 > > An: dev@plc4x.apache.org <dev@plc4x.apache.org> > > Betreff: Re: Board report .... > > Hello Chris, > > > > The S7-300/S7-400 devices have an important group of functions for event > > handling. In the process part (PCS7) this is handled intensively. > > > > At the time, all these operations are on the Tag associated with the > > request, so any service type subscription is a subscription to events. > > > > In general the S7-300/S7-400 support; > > > > - *MODE*: Change of operating state in the controller, change from > STOP > > to RUN and vice versa. > > - *SYS*: System events, associated with internal events of the > > controller or events previously parameterized for their indication. > > - *USR*: Events programmed by the user and that are registered in the > > internal diagnostic buffer. > > - *ALM*: Alarm events generated by the user program, ALARM_S, > ALARM_8, > > NOTIFY. > > - And additionally "*CYC*" cyclic mode transfer. > > > > > > But in general they are all seen as events, hence the inconsistency > pointed > > out by Bjorn. > > > > All these events are implemented, of course, they have many points of > > improvement that must be addressed. > > > > I currently do not have a PN or CP-343-1 CPU for testing with S7-300. > > > > As you point out, with Zylk's contribution it can complement the CP-443-1 > > for redudance tests (thanks Zylk). > > > > Well, the story is long... I'm going for a good coffee. > > > > Kind regards, > > > > El mié, 13 mar 2024 a las 14:57, Christofer Dutz (< > christofer.d...@c-ware.de>) > > escribió: > > > >> Hi Björn, > >> > >> the problem with the subscriptions in S7 are that they do work, but only > >> on S7 300 (I think). > >> I mentioned before on this list, that we should probably do > >> context-sensitive “isXYZSupported” functions. > >> Unfortunately, I haven’t yet had the time to implement them. > >> > >> So, to make it short … in general the S7 protocol doesn’t support > >> subscriptions, except for a small subset of device types. > >> If Cesar could possibly tell me which devices support Subscriptions, I > >> could implement something to make this happen (Shouldn’t be too much > work). > >> > >> One day we’ll probably have simulated subscriptions, but admittedly as > >> nobody really seems to be interested in working on core-services like > this, > >> it’s probably gonna take a while. > >> In the past I was able to work on PLC4X full time, but as no company > >> (except Zylk) was really willing to pay for any form of development, I > had > >> to pick a job that pays the bills. > >> I’m still on it, but doing this in my free time. > >> > >> Chris > >> > >> Von: Björn Haverland <bjo...@coding-nexus.com> > >> Datum: Mittwoch, 13. März 2024 um 18:52 > >> An: dev@plc4x.apache.org <dev@plc4x.apache.org> > >> Betreff: Re: Board report .... > >> Hi, > >> > >> as I'm starting to get used to the project I do have some questions, > >> especially regarding the mentioned v1.0.0. > >> > >> I tried to set up a plc4j with the quickstart guide which utilizes the > S7 > >> protocol. > >> > >> So there are examples, in the example folder as well, which are just not > >> working. (The Subscription for instance) I do understand that the lib > >> hasn't had a Major release yet, but I think it could set people off. > >> > >> I like to suggest to change the docs on that points. I know it is hard > to > >> test everything but if a feature isn't implemented a wrong documentation > >> just leads to frustration. > >> Cesar has implemented a working CyclicSubscription, and I think he is > >> going to merge it to the dev branch soon. But still there are other > >> subscription methods shown which won't work, just yet. > >> > >> I'd like to hear your opinion on this. > >> > >> Best regards > >> > >> Bjoern > >> > >> > >> > >> Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> > >> ________________________________ > >> From: Christofer Dutz <christofer.d...@c-ware.de> > >> Sent: Wednesday, March 13, 2024 12:00:11 PM > >> To: dev@plc4x.apache.org <dev@plc4x.apache.org> > >> Subject: Board report .... > >> > >> Hi all, > >> > >> unfortunately I had almost forgotten to submit the board report after > >> coming back from my little snowboard vacation. > >> I took the liberty of posting the following report. If there are changes > >> you’d like to see, please tell me asap and I can edit it. > >> > >> > >> > >> ## Description: > >> The mission of the Apache PLC4X project is creating a set of libraries > for > >> communicating with industrial programmable logic controllers (PLCs) > using a > >> variety of protocols but with a shared API. > >> > >> ## Project Status: > >> Current project status: Ongoing with moderate activity > >> Issues for the board: None > >> > >> ## Membership Data: > >> Apache PLC4X was founded 2019-04-17 (5 years ago) > >> There are currently 21 committers and 13 PMC members in this project. > >> The Committer-to-PMC ratio is roughly 3:2. > >> > >> Community changes, past quarter: > >> - No new PMC members. Last addition was César García on 2021-10-01. > >> - No new committers. Last addition was Jinlin Hong on 2022-11-02. > >> > >> ## Project Activity: > >> Version 0.12.0 was released on 2024-02-19 > >> > >> The project has been working on closing many issues this quarter. > >> We were able to cut the number of open issues by half. Also did we > >> invest a considerable amount of time for working towards reproducible > >> builds and automating most of the release process. Also did we update > >> the content on the website, especially thanks to a new documentation- > >> generator now the configuration for our drivers is automatically going > >> to be up to date. > >> > >> ## Community Health: > >> We know we haven't invited any new committers for quite some time. > >> This is definitely not due to a high committer bar, but more related > >> to the fact that the people needing Apache PLC4X seem to come from a > >> part of the industry that is completely new to the concept of > open-source. > >> > >> Only very few people accept our offer to mentor them to scratching their > >> own itches. > >> > >> Interestingly the project is gaining more and more popularity on the > user- > >> side. > >> > >> Activity on the mailing lists seems to have increased slightly (8% - 605 > >> emails) > >> > >> The community is looking forward to a community meetup in Frankfurt the > >> weekend after the board meeting. Here we hope to re-ignite some of the > >> community activity and focus on perhaps releasing a 1.0.0 version of > >> PLC4X this year. > >> > > > > > > -- > > *CEOS Automatización, C.A.* > > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > > *Ing. César García* > > > > *Cel: +58 414-760.98.95* > > > > *Hotline Técnica SIEMENS: 0800 1005080* > > > > *Email: support.aan.automat...@siemens.com > > <support.aan.automat...@siemens.com>* > > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com <support.aan.automat...@siemens.com>*
