https://bz.apache.org/bugzilla/show_bug.cgi?id=59853
--- Comment #5 from Greg Woolsey <greg.wool...@gmail.com> --- Created attachment 34110 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34110&action=edit Additional pivot table base data options - Named Range and Table After more vacations than I thought we could pull off in one summer, I finally got this ready. There were some interesting wrinkles down in the weeds, but nothing that affected a broad area of the API. I've refactored the TestXSSFPivotTable class into an abstract base class with the tests, and two concrete subclasses with the setup. Each class sets up the pivot tables differently, one with area references as before, and one with names (named ranges). Both pass with no changes, as they should. I'm open to refactoring ideas for XSSFPivotTable.createSourceReferences() - it now has two mutually exclusive parameters, not my favorite pattern. However, it's protected, and called from exactly one place, which is also overloaded that way, a private method, XSSFSheet.createPivotTable(...). Since those are internal, I was OK with it. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
