https://bz.apache.org/bugzilla/show_bug.cgi?id=59853
--- Comment #8 from Javen O'Neal <one...@apache.org> --- > +++ src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPivotCacheDefinition.java > table.getName().equals(name) Are table names case insensitive or could table.getName() ever have different capitalizaion than wsSource.getName() (such as a sheet rename after the cache is built up?) Would equalsIgnoreCase be better here? Review each String.equals(String) usage to see if it should actually be String.equalsIgnoreCase(String), such as in createPivotTable where sheet names are compared. I agree with you that a method with mutually exclusive parameters is clunky. Can > protected void createSourceReferences(AreaReference sourceRef, String > sourceName, CellReference position, Sheet sourceSheet) be broken into 2 functions? Can sourceName be an XSSFName instead of a String? Also, could you upgrade the unit tests to junit3 instead of junit4 (example: https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTable.java?view=markup)? If not, I will upgrade them when I commit them. Otherwise, looks pretty good. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
