https://bz.apache.org/bugzilla/show_bug.cgi?id=59853
--- Comment #9 from Greg Woolsey <greg.wool...@gmail.com> --- (In reply to Javen O'Neal from comment #8) > > +++ > > src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPivotCacheDefinition.java > > table.getName().equals(name) > Are table names case insensitive Oops, yes, names are insensitive, like range names. I'll find those and fix them. > > I agree with you that a method with mutually exclusive parameters is clunky. > Can > > protected void createSourceReferences(AreaReference sourceRef, String > > sourceName, CellReference position, Sheet sourceSheet) > be broken into 2 functions? Can sourceName be an XSSFName instead of a > String? It would have to be 3 functions, like the createPivotTable methods in XSSFSheet, with duplicated code. The XML overloads the same "name" attribute to reference an XSSFName and an XSSFTable. We could do the 3 object variants, and a functional interface to configure the CTWorksheetSource as needed, passing inline anonymous classes to do that bit of the logic. That would maintain Java6 compatibility and let createSourceReferences not care whether it referenced a name or area. > Also, could you upgrade the unit tests to junit3 instead of junit4 (example: > https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ > xssf/usermodel/TestXSSFTable.java?view=markup)? If not, I will upgrade them > when I commit them. I kept the test the same as it was when I refactored, but I could convert to the older format if that's the preferred standard. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
