Jonathan Robie wrote:
When I wrote client-api-example-tests.py, I assumed I was replacing the
old validate scripts, using the new drain / spout examples, and using
Python unittest.
One developer says that's just what I should do, and tells me to
integrate this into make check. Another says that only broker tests
should be integrated into make check.
Actually what I said was that make check is really only about C++ tests,
and doesn't get run prior to java or python tests, so 'make check' isn't
a suitable entry point for these tests.
That's not to say they can't be integrated into make check, but putting
them in there the same way the validate scripts were is really rather
unfriendly to the non C++ developers as it forces them to sit through
lots of irrelevant C++ tests in order to check interop.
Also, it makes them much less useful as they can only be easily run
against the software built out of the source tree. Interop tests are
about more than just checking that a single snapshot is consistent, they
are also about checking interop against prior versions of the software,
and it's impossible to do this out of a single source tree.
In its current form, it runs for 150 seconds. I can strip that down to
less than a minute and still have very useful smoke tests for the client
examples. What's the best approach?
A. Add the tests, more or less as is, to make check
B. Add a stripped down version to make check
C. Use the tests, but don't add them to make check
D. None of the above
D
In the long run, I can imagine having a very extensive version of this
that tests interop using different AMQP versions, and tests every
feature drain / spout support. We wouldn't want that to run with make
check.
Do we need a new make target for more extensive testing?
I think you should forget about make and simply provide a convenient
command line interface to running the tests (either via qpid-python-test
or a custom script if appropriate).
This can then be used to test interop outside of the source tree and can
be trivially integrated by C++, Java, and/or python developers into
their respective builds.
--Rafael
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
