I'm with Chuck - I'd vote for a hook that you can opt to ignore. Why do we care so much about trailing white space - enough to generate diffs for all files seems too much, unless I'm missing an editor related problem people have ?
There's a long lived maintenance branch from 0.5 that I use, and fixes are fairly often ported from there to trunk as reported/corrected. 1.0 implementation will likely bring another long living branch. I'm not for making merging more difficult than it is already ! Regards, Marnie On Tue, Feb 1, 2011 at 1:18 AM, Chuck Rolke <[email protected]> wrote: > How many files are we talking about here? > > Yes, spurious trailing-white-space diffs are bad but if there's only 20-30 > files then I could live with that. > > My bet is that there are way more files with embedded tabs. > > I'll vote yes for a hook that flags/complains about a commit with tabs or > trailing spaces but lets you check it in anyway. I've seen plenty of > inadvertent tabs in my own code that I'd be happy to fix up. > > -Chuck > > ----- Original Message ----- > > From: "Robbie Gemmell" <[email protected]> > > To: [email protected] > > Sent: Monday, January 31, 2011 6:46:18 PM > > Subject: RE: Zap trailing whitespace? > > > -----Original Message----- > > > From: Steve Huston [mailto:[email protected]] > > > Sent: 31 January 2011 23:18 > > > To: [email protected] > > > Subject: RE: Zap trailing whitespace? > > > > > > > OK, let me try for consensus around this: > > > > > > > > Does anyone object to adding an svn hook that (1) strips trailing > > > > whitespace, and (2) bans commits that contain tabs? > > > > > > I think I'd rather see the hook refuse to do the commit if there are > > > trailing whitespace or tabs. On the off chance that svn gets it > > > wrong > > > for some odd file type, I'd rather final control be left in a > > > person's > > > hands. > > > > > > -Steve > > > > > > > Agreed. > > > > Also, I know many of us use git(-svn). You can do things such as > > enabling > > colouring of whitespace errors in diffs etc, or have git fix certain > > whitespace errors automatically, or use some additional pre-commit > > hooks > > there too...basically there are various ways it could/can help in > > getting > > such things out of the way before SVN even enters the picture. > > > > > > Robbie. > > > > > > --------------------------------------------------------------------- > > Apache Qpid - AMQP Messaging Implementation > > Project: http://qpid.apache.org > > Use/Interact: mailto:[email protected] > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > >
