On Mon, 2011-01-31 at 18:21 -0500, Andrew Stitcher wrote: > On Mon, 2011-01-31 at 18:17 -0500, Steve Huston wrote: > > > OK, let me try for consensus around this: > > > > > > Does anyone object to adding an svn hook that (1) strips trailing > > > whitespace, and (2) bans commits that contain tabs? > > > > I think I'd rather see the hook refuse to do the commit if there are > > trailing whitespace or tabs. On the off chance that svn gets it wrong > > for some odd file type, I'd rather final control be left in a person's > > hands. > > I'm ok with this approach, but it still leaves the ultimate control in > the hook though! As it won't be possible to commit anything it doesn't > like, no matter how much you want!
I agree that there is no good reason for trailing whitespace in any of the _coding languages_ we care about, but don't make the hooks too broad. I can easily envision cases where trailing whitespaces may be used by data files, templates, binary and other non-language files. Kim --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
