-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/
-----------------------------------------------------------

(Updated 2011-02-22 08:30:24.350312)


Review request for qpid.


Changes
-------

Update from Kevin Conner:

QpidRAManagedConnection.java
  work around but in qpid, I believe Gordon has fixed it
QpidRAProperties.java
  Force configuration of transaction manager lookup rather than default
QpidResourceAdapter.java
  Add missing RA properties for TM etc.

inflow/QpidActivation.java
  Move to single connection for inflow, handle failures
  Relax destination detection per review comments
inflow/QpidMessageHandler.java
  Move connection for inflow

resources/META-INF/ra.xml
  Add comments for additional properties


Summary (updated)
-------

Review for a qpid JCA resource adapter.

So far no build infrastructure is included.

I'd also like an opinion as to whether java/jca is the appropriate name for 
this (I'm thinking perhaps java/ra would be more usual).

Any and all comments welcome.


This addresses bug QPID-3044.
    https://issues.apache.org/jira/browse/QPID-3044


Diffs (updated)
-----

  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION 
  /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN 

Diff: https://reviews.apache.org/r/441/diff


Testing
-------


Thanks,

Andrew

Reply via email to