A few notes about the JCA code/review: Unfortunately I somehow screwed up and couldn't get the previous ReviewBoard review to update with new changes. So I've created a new ReviewBoard review - https://reviews.apache.org/r/432 I certainly hope that we'll be able to use that going on (assuming there is much more to say!)
Just to explain the provenance of the code: The original code comes from the HornetQ JCA resource adapter. The copyright owner of this is Red Hat and it has given permission for it to be submitted to the Qpid project. The original code was Apache Licensed anyway so there was no bug deal here. Therefore we are using the regular Apache License text. Because of this there may still be some holdovers of code/formatting standards - please let us know about anything like this and we'll fix it. Because the Red Hat Qpid team has very limited experience in J2EE we've been helped (a lot) by Kevin Conner who also works for Red Hat in the JBoss group, that's why you will have seen him commenting on the review changes. Andrew --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org