I don't believe that there's been a response to my comments about testing on the Review Board or the JIRA.
On this task, I consider the lack of tests, documentation (is there any?) and possibly intent to maintain the code from the author to preclude commit. I'd be glad to hear any response on the issues being raised here, and for some further discussion. Is this a likely candidate to be set up as a plugin for the broker and contributed to a sandbox space ? Thanks, Marnie On Wed, Feb 23, 2011 at 4:43 PM, Marnie McCormack < marnie.mccorm...@googlemail.com> wrote: > Do none of the classes have unit tests ? > > I can understand the possible dependencies for system/integration tests but > 0% unit test coverage is not ideal. > > Thanks, > Marnie > > On Wed, Feb 23, 2011 at 2:53 PM, Andrew Stitcher > <astitc...@redhat.com>wrote: > >> On Wed, 2011-02-23 at 13:54 +0000, Marnie McCormack wrote: >> > Hi Andrew, >> > >> > My comment on the new code, from an initial glance is that it doesn't >> seem >> > to have any tests - are these attached somewhere else ? >> >> Currently the adapter is being tested against the JCA TCK and JBoss EAP >> as the container. I don't think it makes sense to check these >> dependencies in (and I expect we can't for the TCK anyway). >> >> I will give some thought to what tests we could meaningfully check in - >> anyone with suggestions please pipe up. >> >> Andrew >> >> >> >> --------------------------------------------------------------------- >> Apache Qpid - AMQP Messaging Implementation >> Project: http://qpid.apache.org >> Use/Interact: mailto:dev-subscr...@qpid.apache.org >> >> >
