----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5529/#review8535 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp <https://reviews.apache.org/r/5529/#comment18199> I agree with Andrew. This addition is less than ideal, not least because it only addresses the code path for plain TCP, not SSL or RDMA. The appropriate way to close quietly is to call ConnectionOutputHandler::close() from within the broker code. Perhaps we can catch the exception in qpid::broker::Connection::received()? It's really a contract with components such as the connection observers around what different exception types mean. - Gordon Sim On June 22, 2012, 8:18 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5529/ > ----------------------------------------------------------- > > (Updated June 22, 2012, 8:18 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > A HA backup broker rejects client connections by throwing out of > ConnectionObserver::opened. > This is not an error, but generates a lot of noise in the form of error > log messages. > This patch throws a ClosedException in this case and has the exception > handler generate a debug > message instead of an error if it catches ClosedException. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/ha/BackupConnectionExcluder.h 1353017 > /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp 1353017 > /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1353017 > > Diff: https://reviews.apache.org/r/5529/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alan Conway > >
