----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5529/ -----------------------------------------------------------
(Updated June 27, 2012, 10:14 p.m.) Review request for qpid, Andrew Stitcher and Gordon Sim. Changes ------- updated description Description (updated) ------- A HA backup broker used to reject client connections by throwing out of ConnectionObserver::opened. This is not an error, but generates a lot of noise in the form of error log messages. This patch calls Connection::abort() instead of throwing, which does not leave any error log messages. NOTE: I use abort() instead of close() because the clients will not retry a connection that is closed, they will retry if the connection is aborted. Diffs ----- /trunk/qpid/cpp/src/qpid/ha/BackupConnectionExcluder.h 1354717 /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp 1354717 Diff: https://reviews.apache.org/r/5529/diff/ Testing ------- make check Thanks, Alan Conway