----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5529/#review8678 -----------------------------------------------------------
This version seems much simpler and preferable to me than the previous version. /trunk/qpid/cpp/src/qpid/ha/BackupConnectionExcluder.h <https://reviews.apache.org/r/5529/#comment18342> Why don't you pay attention to this comment and make the following log statement info? /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp <https://reviews.apache.org/r/5529/#comment18343> As previous comment. Though looking again I'm not really sure what this comment actually means - has it been overtaken by code changes? - Andrew Stitcher On June 27, 2012, 10:14 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5529/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 10:14 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > A HA backup broker used to reject client connections by throwing out of > ConnectionObserver::opened. > This is not an error, but generates a lot of noise in the form of error log > messages. > This patch calls Connection::abort() instead of throwing, which does not > leave any error log messages. > > NOTE: I use abort() instead of close() because the clients will not retry a > connection that > is closed, they will retry if the connection is aborted. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/ha/BackupConnectionExcluder.h 1354717 > /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp 1354717 > > Diff: https://reviews.apache.org/r/5529/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alan Conway > >
