----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22528/ -----------------------------------------------------------
(Updated June 12, 2014, 8:38 p.m.) Review request for qpid, Kenneth Giusti and Rafael Schloming. Changes ------- the actual diff Bugs: PROTON-606 https://issues.apache.org/jira/browse/PROTON-606 Repository: qpid Description ------- On windows (python 2.6.1) the server in testCreditRebalance won't shut down when client2 in the test is not stopped. Since the test may assert at a random place there's no way to guarantee client2's state. * Promote test client2 messenger to be a full class member * In teardown() when a messenger's outgoing > 0 then call settle() * In teardown() while incoming > 0 call get() * Add a new test that formerly hung the server but is now fixed Diffs (updated) ----- proton/trunk/tests/python/proton_tests/messenger.py 1602016 Diff: https://reviews.apache.org/r/22528/diff/ Testing ------- works on linux and windows. Thanks, Chug Rolke