-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22528/
-----------------------------------------------------------
(Updated June 13, 2014, 3:17 p.m.)
Review request for qpid, Kenneth Giusti and Rafael Schloming.
Changes
-------
This patch does away with the .incoming and .outgoing flush code. Also, the
main issue fixed here is the pump loop. Pulling client2 into the loop makes the
original test behave itself[1] and print the assert messages from the original
assert without having a broker/client stopped assert overwrite it.
[1] However, inserting an assert between a put() and pump() causes a core dump
on both windows and linux. Calling settled and get works around that issue and
that's where that code came from. A new bug is forthcoming.
Bugs: PROTON-606
https://issues.apache.org/jira/browse/PROTON-606
Repository: qpid
Description
-------
On windows (python 2.6.1) the server in testCreditRebalance won't shut down
when client2 in the test is not stopped. Since the test may assert at a random
place there's no way to guarantee client2's state.
* Promote test client2 messenger to be a full class member
* In teardown() when a messenger's outgoing > 0 then call settle()
* In teardown() while incoming > 0 call get()
* Add a new test that formerly hung the server but is now fixed
Diffs (updated)
-----
proton/trunk/tests/python/proton_tests/messenger.py 1602016
Diff: https://reviews.apache.org/r/22528/diff/
Testing
-------
works on linux and windows.
Thanks,
Chug Rolke
