----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22528/#review45610 -----------------------------------------------------------
proton/trunk/tests/python/proton_tests/messenger.py <https://reviews.apache.org/r/22528/#comment80488> Question for Rafi - why is this 'manual flushing' necessary? It implies that messenger will never reach 'stopped' unless the application manually monitors incoming/outgoing and keeps cleaning up. I didn't expect this to be needed. proton/trunk/tests/python/proton_tests/messenger.py <https://reviews.apache.org/r/22528/#comment80489> Doesn't this suffer from the original race condition too? Specifically, if the rebalancer kicks in during the previous pump, these asserts will fail, no? - Kenneth Giusti On June 12, 2014, 8:38 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22528/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 8:38 p.m.) > > > Review request for qpid, Kenneth Giusti and Rafael Schloming. > > > Bugs: PROTON-606 > https://issues.apache.org/jira/browse/PROTON-606 > > > Repository: qpid > > > Description > ------- > > On windows (python 2.6.1) the server in testCreditRebalance won't shut down > when client2 in the test is not stopped. Since the test may assert at a > random place there's no way to guarantee client2's state. > > * Promote test client2 messenger to be a full class member > * In teardown() when a messenger's outgoing > 0 then call settle() > * In teardown() while incoming > 0 call get() > * Add a new test that formerly hung the server but is now fixed > > > Diffs > ----- > > proton/trunk/tests/python/proton_tests/messenger.py 1602016 > > Diff: https://reviews.apache.org/r/22528/diff/ > > > Testing > ------- > > works on linux and windows. > > > Thanks, > > Chug Rolke > >
