[ https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210784#comment-16210784 ]
Adel Boutros commented on QPID-7910: ------------------------------------ Thanks [~alex.rufous], I have some questions, remarks: # Shouldn't we limit the stop to the current user's processes? (What would happen if he tries to kill a broker which he cannot kill due to lack of permissions?) # I don't think we need to distinguish between single process or multiple ones (lines 31 and 32 can be grouped with the one on line 34) # Can you please refactor the duplicated "org.apache.qpid.server.Main" and store it in a variable? # If kill never succeeds in killing the broker, the script will be looping indefinitely. Is this the expected behavior? Regards, Adel > [Java Broker] Improve qpid.stop script > -------------------------------------- > > Key: QPID-7910 > URL: https://issues.apache.org/jira/browse/QPID-7910 > Project: Qpid > Issue Type: Improvement > Components: Java Broker > Reporter: Alex Rudyy > Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: qpid-stop > > > Java Broker qpid.stop needs improvements: > * it currently tries to send SIGTERM and SIGKILL commands twice. It is > superfluous. Sending event once should be sufficient. > * we can use {{kill -0}} to verify the process instead of using ps > * make {{$SLEEP_DELAY}} overridable from command line > * script should be able to wait until Qpid processes are killed before exiting -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org