[ https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210830#comment-16210830 ]
Alex Rudyy commented on QPID-7910: ---------------------------------- Adel, I uploaded a new version of the script allowing to specify multiple pids from command line. I also removed references to "org.apache.qpid.server.Main" and replaced them with old style PNAME search string for backward compatibility. The search string can be set via environment variable in similar way as in older script. I am going to make further changes to restricts broker process to current user. Though, I think it is not necessary, as attempt to kill the process without permissions would end-up in kill returning non-zero exit code. The script only waits for processes if kill TERM is successful. If kill TERM will not terminate the process, the script would be looping indefinitely. Potentially, I can modify the script to wait for some arbitrary timeout like 1hour if it is required. Though, if script takes long time to execute, that might require operator intervention anyway. Operator would need to investigate and kill broker and stop script. What do you think? > [Java Broker] Improve qpid.stop script > -------------------------------------- > > Key: QPID-7910 > URL: https://issues.apache.org/jira/browse/QPID-7910 > Project: Qpid > Issue Type: Improvement > Components: Java Broker > Reporter: Alex Rudyy > Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: qpid-stop > > > Java Broker qpid.stop needs improvements: > * it currently tries to send SIGTERM and SIGKILL commands twice. It is > superfluous. Sending event once should be sufficient. > * we can use {{kill -0}} to verify the process instead of using ps > * make {{$SLEEP_DELAY}} overridable from command line > * script should be able to wait until Qpid processes are killed before exiting -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org