[ 
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220725#comment-16220725
 ] 

Alex Rudyy commented on QPID-7910:
----------------------------------

Changes in commits [ 
https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c2661b8 ] [ 
https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b2c5537 ] and [ 
https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=cd12e2d ] look 
good to me

> [Java Broker] Improve qpid.stop script
> --------------------------------------
>
>                 Key: QPID-7910
>                 URL: https://issues.apache.org/jira/browse/QPID-7910
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>            Priority: Minor
>             Fix For: qpid-java-broker-7.0.0
>
>         Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop  needs improvements:
> * it  currently tries to send SIGTERM and SIGKILL commands twice. It is 
> superfluous. Sending event once should be sufficient. 
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to