[ https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942683#comment-16942683 ]
Ulf Lilleengen commented on PROTON-2105: ---------------------------------------- [~rkieley] thanks for looking at this. I'm thinking the problem with using github.com in the module URL is that this has not been the authorative module name in the past, so changing that I'm not sure is something we should do (i'm a bit confused after reading go/src/qpid.apache.org/readme-go-get.md). After your first comment, I thought how it should be is that the following file should go into the go/src/qpid.apache.org folder: {code:java} module qpid.apache.org go 1.13{code} However, I don't see a way to properly test this without actually publishing the go module, because with go modules you're not supposed to use $GOPATH to look up dependencies, but I'm not sure how one can test it locally then. Maybe [~aconway] can shed some light on how the go artifacts are published? > Support Go modules > ------------------ > > Key: PROTON-2105 > URL: https://issues.apache.org/jira/browse/PROTON-2105 > Project: Qpid Proton > Issue Type: Bug > Components: go-binding > Reporter: Ulf Lilleengen > Assignee: Roddie Kieley > Priority: Major > > As of Go 1.12, go module support is available. In order to manage > dependencies using go modules, dependencies must also be using go modules. > Therefore, adding a go.mod file to each module would allow qpid proton go > bindings to be managed as a go module. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org