[ 
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950655#comment-16950655
 ] 

Roddie Kieley commented on PROTON-2105:
---------------------------------------

[~lulf][~aconway] Had thought I would need to do something with the GO111MODULE 
env var but it turns out that in Travis CI the matrix'd linux build and the 
Xcode10.1 macOS image were failing simply because they had go 1.11 and NOT 1.12 
as the require statement specified in the go.mod file. The Xcode 8.3 build was 
failing as it is configured with go 1.9.

I relaxed the go.mod require version to 1.11 and updated the .travis.yml to 
explicitly set it to build for the macOS Xcode10.1 image and to NOT build for 
the macOS Xcode8.3 based image. This resulted in a passing travis ci via [build 
#2183https://www.travis-ci.org/apache/qpid-proton/builds/597417689]

Not sure what else needs to be done here as it should build and the tests 
should run successfully in most cases now assuming the require version is met. 
Thoughts?

> Support Go modules
> ------------------
>
>                 Key: PROTON-2105
>                 URL: https://issues.apache.org/jira/browse/PROTON-2105
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: go-binding
>            Reporter: Ulf Lilleengen
>            Assignee: Roddie Kieley
>            Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage 
> dependencies using go modules, dependencies must also be using go modules. 
> Therefore, adding a go.mod file to each module would allow qpid proton go 
> bindings to be managed as a go module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to