[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968832#comment-16968832 ]
ASF GitHub Bot commented on DISPATCH-1439: ------------------------------------------ codecov-io commented on issue #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#issuecomment-550571158 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=h1) Report > Merging [#614](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/2bd5061938b5ce5d59e02af6eb5f89c8862362b5?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/614/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #614 +/- ## ========================================== - Coverage 86.44% 86.43% -0.01% ========================================== Files 91 91 Lines 20613 20633 +20 ========================================== + Hits 17818 17834 +16 - Misses 2795 2799 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.96% <100%> (+0.04%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.33% <100%> (+0.04%)` | :arrow_up: | | [src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j) | `97.08% <100%> (+0.08%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <100%> (-0.56%)` | :arrow_down: | | [src/router\_core/agent\_connection.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5lY3Rpb24uYw==) | `82.12% <100%> (+0.46%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.4%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.97% <0%> (ø)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `81.37% <0%> (+0.18%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=footer). Last update [2bd5061...6218328](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > ------------------------------------------------------------------------------ > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement > Reporter: Keith Wall > Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org