[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969017#comment-16969017
]
ASF GitHub Bot commented on DISPATCH-1439:
------------------------------------------
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343515001
##########
File path: src/router_core/agent_router.c
##########
@@ -233,6 +235,13 @@ static void qdr_agent_write_column_CT(qd_composed_field_t
*body, int col, qdr_co
qd_compose_insert_uint(body, core->links_blocked);
break;
+ case QDR_ROUTER_UPTIME_SECONDS:
+ if (core->uptime_ticks== 0)
+ qd_compose_insert_uint(body, 0);
Review comment:
This if-then-else doesn't seem to be any different from simply calling
qs_compose_insert_uint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Keith Wall
> Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
