[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969356#comment-16969356
]
ASF GitHub Bot commented on DISPATCH-1439:
------------------------------------------
ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two
attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343718843
##########
File path: src/router_core/agent_connection.c
##########
@@ -240,6 +245,17 @@ static void qdr_connection_insert_column_CT(qdr_core_t
*core, qdr_connection_t *
qd_compose_insert_string(body, text);
break;
+ case QDR_CONNECTION_UPTIME_SECONDS:
+ qd_compose_insert_uint(body, core->uptime_ticks - conn->conn_uptime);
+ break;
+
+ case QDR_CONNECTION_LAST_DLV_SECONDS:
+ if (conn->is_delivery_sent)
+ qd_compose_insert_uint(body, core->uptime_ticks -
conn->last_delivery_time);
+ else
+ qd_compose_insert_string(body, "-");
Review comment:
Changed this to insert null instead of "-"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Keith Wall
> Assignee: Ganesh Murthy
> Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
