[
https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993814#comment-16993814
]
ASF GitHub Bot commented on DISPATCH-1514:
------------------------------------------
kgiusti commented on pull request #641: DISPATCH-1514 - Dynamically turned on
proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770256
##########
File path: src/server.c
##########
@@ -1276,6 +1277,25 @@ void qd_server_set_container(qd_dispatch_t *qd,
qd_container_t *container)
qd->server->container = container;
}
+void qd_server_trace_all_connections()
+{
+ qd_dispatch_t *qd = qd_dispatch_get_dispatch();
+ if (qd->server) {
+ qd_connection_list_t conn_list = qd->server->conn_list;
+ qd_connection_t *conn = DEQ_HEAD(conn_list);
+ while(conn) {
Review comment:
the qd->server->conn_list is protected by qd->server->lock. this loop will
need to hold that lock while walking the list or it is possible the connection
it is working on is removed (and possibly freed) by another thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamically turning on trace logging via qdmanage does not turn proton frame
> tracing on existing connections
> ------------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1514
> URL: https://issues.apache.org/jira/browse/DISPATCH-1514
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.9.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
> Steps to reproduce -
> # Start a router
> # Connect a sender and receiver to the router and let them send/receive
> message
> # While the sender and receiver are sending/receiving, use qdmanage to turn
> on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+
> # Notice that the trace logging for the sender and receiver were not turned
> on,
> # Turning on trace logging must enable proton trace logging on existing
> connections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
