[
https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993815#comment-16993815
]
ASF GitHub Bot commented on DISPATCH-1514:
------------------------------------------
kgiusti commented on pull request #641: DISPATCH-1514 - Dynamically turned on
proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770898
##########
File path: src/log.c
##########
@@ -541,7 +542,16 @@ qd_error_t qd_log_entity(qd_entity_t *entity) {
if (qd_entity_has(entity, "enable")) {
enable = qd_entity_get_string(entity, "enable");
QD_ERROR_BREAK();
+
src->mask = enable_mask(enable);
+
+ //
+ // If trace logging is enabled, loop thru all connections in the
router and call the pn_transport_set_tracer callback
+ // so proton frame trace can be output as part of the router trace
log.
+ //
+ if (qd_log_enabled(src, QD_LOG_TRACE)) {
Review comment:
would it be possible to move this outside of the log_source_lock? For
example, just set a flag here then check the flag after dropping the lock and
making the call to qd_server_trace_all_connections() then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamically turning on trace logging via qdmanage does not turn proton frame
> tracing on existing connections
> ------------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1514
> URL: https://issues.apache.org/jira/browse/DISPATCH-1514
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.9.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
> Steps to reproduce -
> # Start a router
> # Connect a sender and receiver to the router and let them send/receive
> message
> # While the sender and receiver are sending/receiving, use qdmanage to turn
> on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+
> # Notice that the trace logging for the sender and receiver were not turned
> on,
> # Turning on trace logging must enable proton trace logging on existing
> connections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
