[
https://issues.apache.org/jira/browse/DISPATCH-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993856#comment-16993856
]
ASF GitHub Bot commented on DISPATCH-1514:
------------------------------------------
codecov-io commented on issue #641: DISPATCH-1514 - Dynamically turned on
proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#issuecomment-564266612
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=h1)
Report
> Merging
[#641](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/d7f8d4d0a774b0914ec86f6113b0126be111fabc?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 86.5% 86.52% +0.02%
==========================================
Files 91 91
Lines 20631 20651 +20
==========================================
+ Hits 17847 17869 +22
+ Misses 2784 2782 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=)
| `83.15% <100%> (+0.17%)` | :arrow_up: |
|
[src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr&el=tree#diff-c3JjL2xvZy5j)
| `90.23% <100%> (+0.16%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.32% <84.61%> (-0.03%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/641/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.23% <0%> (+0.23%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=footer).
Last update
[d7f8d4d...064f0b7](https://codecov.io/gh/apache/qpid-dispatch/pull/641?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamically turning on trace logging via qdmanage does not turn proton frame
> tracing on existing connections
> ------------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1514
> URL: https://issues.apache.org/jira/browse/DISPATCH-1514
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.9.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
> Steps to reproduce -
> # Start a router
> # Connect a sender and receiver to the router and let them send/receive
> message
> # While the sender and receiver are sending/receiving, use qdmanage to turn
> on trace logging - qdmanage update --type=log name=log/DEFAULT enable=trace+
> # Notice that the trace logging for the sender and receiver were not turned
> on,
> # Turning on trace logging must enable proton trace logging on existing
> connections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
