mgoulish commented on a change in pull request #1239:
URL: https://github.com/apache/qpid-dispatch/pull/1239#discussion_r643111160
##########
File path: src/log.c
##########
@@ -379,7 +398,14 @@ qd_log_source_t *qd_log_source(const char *module)
{
sys_mutex_lock(log_source_lock);
qd_log_source_t* src = qd_log_source_lh(module);
+ // Note to Mick: Mick! Please don't access log_source fields
+ // outside of the log_source lock. That's why there's a lock, you know.
+ bool add_me = src->add_me;
Review comment:
How about add_me_or_else ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
