ganeshmurthy commented on a change in pull request #1239:
URL: https://github.com/apache/qpid-dispatch/pull/1239#discussion_r643210620
##########
File path: src/log.c
##########
@@ -518,6 +544,7 @@ void qd_log_initialize(void)
default_log_source->includeTimestamp = true;
default_log_source->includeSource = 0;
default_log_source->sink = log_sink_lh(SINK_STDERR);
+ default_log_source->add_log_stats = false;
Review comment:
If you look at
https://github.com/apache/qpid-dispatch/blob/main/src/log.c#L368, the
ZERO(log_source); is called. This sets all bits to 0 on the log_source which
then automatically sets the add_log_stats to false, so no need to set the
add_log_stats explicitly to false in qd_log_source_defaults() which is called
right after the call to ZERO(log_source);
But yes, if ZERO(log_source); was not called in the future, then
qd_log_source_defaults() would take care of defaulting the add_log_stats flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
