ganeshmurthy commented on a change in pull request #1239:
URL: https://github.com/apache/qpid-dispatch/pull/1239#discussion_r643192133
##########
File path: src/log.c
##########
@@ -648,8 +685,12 @@ qd_error_t qd_log_entity(qd_entity_t *entity)
src->includeSource = include_source;
}
+ bool add_log_stats = src->add_log_stats;
+ src->add_log_stats = false;
sys_mutex_unlock(log_source_lock);
-
+ if(add_log_stats) {
+ qd_entity_cache_add(QD_LOG_STATS_TYPE, src);
Review comment:
I am unsure why we need to add the QD_LOG_STATS_TYPE here ?
I commented this line and the logStats was still created because
qd_log_source() is creating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
