Good discussion! I see a mix of approaches to opening PR in Quickstep and we do not have a set policy.
I believe, Saket and Tarun use the model that Julian recommends. Great idea switching to it! Cheers, Jignesh On 11/5/16, 2:51 PM, "Hakan Memisoglu" <[email protected]> wrote: Hi, The workflow that Julian mentioned is better than what we are doing right now. As Harshad pointed out, we were thinking that it was against Apache policy. On 11/05/2016 02:15 PM, Harshad Deshmukh wrote: > Hi Julian, > > No, there's no such policy. I think majority of the contributors use > their individual GitHub accounts and also initiate pull request from > the same. Some of us started with the practice of using Apache repo > and continue to do so. If using individual GitHub accounts is > preferred we all can switch to that mode. > > On 11/05/2016 12:45 PM, Julian Hyde wrote: >> Regarding my other point: does Quickstep have a policy that pull >> requests should, or must, come from the Apache github account? If so, >> can you see how that would tend to discourage people from joining the >> community? Because only committers are able to push to Apache. >> >> Several projects use "feature branches", where multiple developers >> need to collaborate over a long period, and of course a branch or tag >> per release, but other than that, branches in the Apache repo are >> quite unusual. >> >> Julian >> >>> On Nov 4, 2016, at 11:25 AM, Harshad Deshmukh <[email protected]> >>> wrote: >>> >>> Thanks Julian, your suggestion worked! >>> >>> >>>> On 11/04/2016 11:29 AM, Julian Hyde wrote: >>>> If I recall, there is an issue with Apache-github integration that >>>> a branch only shows up when you make a commit on it. So maybe make >>>> a trivial commit. >>>> >>>> That said, you don’t need to push a branch to Apache in order to >>>> make a pull request. You can make a pull request from your own >>>> personal GitHub fork. That’s usually the right thing to do. >>>> >>>> Julian >>>> >>>>> On Nov 4, 2016, at 8:42 AM, Harshad Deshmukh <[email protected]> >>>>> wrote: >>>>> >>>>> Hello, >>>>> >>>>> I pushed a branch (named auto-worker-pinning) to the apache >>>>> repository 11 hours ago. That branch is still not showing up on >>>>> the GitHub mirror. Has any one else experienced similar issue? >>>>> Without the branch showing up on GitHub, I can't create a pull >>>>> request for it. >>>>> >>>>> -- >>>>> >>>>> Thanks, >>>>> Harshad >>>>> >>> -- >>> Thanks, >>> Harshad >>> >
