> On April 13, 2018, 5:28 a.m., Qiang Zhang wrote:
> > Added logs will reduce program performance.
>
> bhavik patel wrote:
> Currently if we get any error message then it will be very difficult to
> debug so it will be helpful to debug the code at the time of any error.
if(logger.isDebugEnabled()) {
logger.debug("“);
}
You can add the above code segment.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201086
-----------------------------------------------------------
On April 13, 2018, 5:14 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 5:14 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj,
> Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java
> b9d948f
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e
> src/main/assembly/kms.xml 68512ef
>
>
> Diff: https://reviews.apache.org/r/66598/diff/1/
>
>
> Testing
> -------
>
> 1. Verified Ranger Kms is working as expected.
>
>
> Thanks,
>
> bhavik patel
>
>
