----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201089 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Lines 151 (patched) <https://reviews.apache.org/r/66598/#comment282059> I feel only debug message is need not Info. kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Lines 370 (patched) <https://reviews.apache.org/r/66598/#comment282056> Do we need to Info level logs? We don't a log of Info logs, debug logs are fine. basically we want to avoid lot of info messages for KMS when you need debug we can put. kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Lines 408 (patched) <https://reviews.apache.org/r/66598/#comment282057> please consider doing logger.error("Keystore was tampered with, or password was incorrect.", t.getMessage()); for getting the entire stack trace into the kms.log file. Please review all the occurance like this where + e.getMessage() is used kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Line 452 (original), 471 (patched) <https://reviews.apache.org/r/66598/#comment282055> do we need to do this printStackTraces? Just leave in log file. Also do Logger.error("==>RangerKeyStore.dbOperationLoad() error, e); kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java Lines 212 (patched) <https://reviews.apache.org/r/66598/#comment282058> Do we need the info level log for the all the decrypts done? - Ramesh Mani On April 13, 2018, 5:14 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66598/ > ----------------------------------------------------------- > > (Updated April 13, 2018, 5:14 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2043 > https://issues.apache.org/jira/browse/RANGER-2043 > > > Repository: ranger > > > Description > ------- > > Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs. > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > b9d948f > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e > src/main/assembly/kms.xml 68512ef > > > Diff: https://reviews.apache.org/r/66598/diff/1/ > > > Testing > ------- > > 1. Verified Ranger Kms is working as expected. > > > Thanks, > > bhavik patel > >
