-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201376
-----------------------------------------------------------
Please fix warning message.
Applying: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have
more debug logs
.git/rebase-apply/patch:109: space before tab in indent.
if (logger.isDebugEnabled()) {
.git/rebase-apply/patch:110: space before tab in indent.
logger.debug("==> RangerKeyStore.engineGetKey()");
.git/rebase-apply/patch:111: space before tab in indent.
}
.git/rebase-apply/patch:131: space before tab in indent.
if (logger.isDebugEnabled()) {
.git/rebase-apply/patch:132: space before tab in indent.
logger.debug("==> RangerKeyStore.addKeyEntry()");
warning: squelched 67 whitespace errors
warning: 72 lines add whitespace errors.
- Qiang Zhang
On April 16, 2018, 5:57 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 5:57 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj,
> Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
>
>
> Diffs
> -----
>
> kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION
> kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java
> b9d948f
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e
>
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
> PRE-CREATION
>
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
> PRE-CREATION
> src/main/assembly/kms.xml 68512ef
>
>
> Diff: https://reviews.apache.org/r/66598/diff/2/
>
>
> Testing
> -------
>
> 1. Verified Ranger Kms is working as expected.
>
>
> Thanks,
>
> bhavik patel
>
>
