> On Aug. 8, 2023, 11:26 a.m., Ramachandran Krishnan wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > > Lines 119 (patched) > > <https://reviews.apache.org/r/74538/diff/1/?file=2278072#file2278072line119> > > > > Can we make it understand feature flag via plugin properties whether > > this needs to be enabled or not ?
I have added config flag "ranger.metrics.enabled" for enabling metrics - Sai Sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74538/#review225633 ----------------------------------------------------------- On Aug. 8, 2023, 3:32 p.m., Sai Sandeep Rangisetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74538/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2023, 3:32 p.m.) > > > Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramachandran Krishnan. > > > Bugs: RANGER-4345 > https://issues.apache.org/jira/browse/RANGER-4345 > > > Repository: ranger > > > Description > ------- > > Add metrics in the plugins for increased visibility on what is happening in > the systems > > > Diffs > ----- > > agents-common/pom.xml b753c1368 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfigConstants.java > 374c78c5e > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > c130309ea > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403 > > > Diff: https://reviews.apache.org/r/74538/diff/2/ > > > Testing > ------- > > Compiled and installed the hbase plugin and verified that metrics are being > published to jmx. Simulated failures by blocking port and verified timeout > and retry metrics are also being published > > > Thanks, > > Sai Sandeep Rangisetti > >