> On Aug. 8, 2023, 10:45 p.m., Ramesh Mani wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > > Lines 121 (patched) > > <https://reviews.apache.org/r/74538/diff/2/?file=2278101#file2278101line121> > > > > Thanks for the contribution. > > Could you please have the MetricRegistry() as a generic > > RangerMetricRegistry() in org.apache.ranger.plugin.util package of > > agents-common module and have the other services like PolicyRefresh which > > you have implemented on can utilize it? > > Sai Sandeep Rangisetti wrote: > Should I make it static/singleton class or should it be so that all the > classes like PolicyRefresher or RangerRESTClient make thier own instance of > RangerMetricRegistry. Is there a better way I can depend on > RangerMetricRegistry.
Please make it as regular class so other services can instantiate it. Since plugins are the one which is going to use it lets have it agents-common only. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74538/#review225639 ----------------------------------------------------------- On Aug. 8, 2023, 3:32 p.m., Sai Sandeep Rangisetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74538/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2023, 3:32 p.m.) > > > Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramachandran Krishnan. > > > Bugs: RANGER-4345 > https://issues.apache.org/jira/browse/RANGER-4345 > > > Repository: ranger > > > Description > ------- > > Add metrics in the plugins for increased visibility on what is happening in > the systems > > > Diffs > ----- > > agents-common/pom.xml b753c1368 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfigConstants.java > 374c78c5e > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > c130309ea > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403 > > > Diff: https://reviews.apache.org/r/74538/diff/2/ > > > Testing > ------- > > Compiled and installed the hbase plugin and verified that metrics are being > published to jmx. Simulated failures by blocking port and verified timeout > and retry metrics are also being published > > > Thanks, > > Sai Sandeep Rangisetti > >
