fateh288 commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2326301879
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -583,6 +584,9 @@ public void setPolicies(ServicePolicies policies) {
setServiceConfigs(policies.getServiceConfig());
+ this.synchronousPolicyRefresh =
isSynchronousPolicyRefresh();
Review Comment:
@vyommani
Thanks a lot for your comments.
We cannot call refreshPoliciesAndTags from each test as the synchronous
policy download config has been developed for ranger integration tests and not
unit tests wherein we have control of when to call this method. The components
still will call call only isAccessAllowed and not any other methods.
As you mentioned, the performance impact will be minimal since its just a
boolean check.
The config is not exposed via UI for any component. The config can only be
enabled by ranger admins so while there is a possibility of misconfiguration, I
consider it as a low risk as misconfiguration of any property in general can
lead to performance degradation.
I think that configuration management by admins or any privileged users is
in general a safe idea as one signs up for any side effects when any config
changes are made.
@mneethiraj can add any additional comments on what is his opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
