vyommani commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2336094542
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -583,6 +584,9 @@ public void setPolicies(ServicePolicies policies) {
setServiceConfigs(policies.getServiceConfig());
+ this.synchronousPolicyRefresh =
isSynchronousPolicyRefresh();
Review Comment:
@fateh288
Have you considered adding a new method as shown below?
public RangerAccessResult isAccessAllowedSync(RangerAccessRequest request) {
refreshPoliciesAndTags();
return isAccessAllowed(request);
}
This approach keeps the existing isAccessAllowed method unchanged and allows
you to use the new method to reduce the execution time of your integration
tests. If you decide against adding a new method, please provide a report
detailing any performance impact of your code changes. I strongly recommend
adding the new method rather than modifying the existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
