mneethiraj commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2337235005
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -583,6 +584,9 @@ public void setPolicies(ServicePolicies policies) {
setServiceConfigs(policies.getServiceConfig());
+ this.synchronousPolicyRefresh =
isSynchronousPolicyRefresh();
Review Comment:
@vyommani - with this approach (of having `isAccessAllowedSync()` methods),
every plugin must be updated to call `*Sync()` method version instead of
existing calls to`isAccessAllowed()` methods when a flag is set. This will be a
significant task, involving updates to large number of modules (20+ plugins?).
The performance impact of additional `if` on a boolean member in each authz
call should be negligible. I suggest avoiding updates to large number of
modules, and go with the approach in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
