vyommani commented on code in PR #768:
URL: https://github.com/apache/ranger/pull/768#discussion_r2617909291
##########
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessorTest.java:
##########
@@ -517,95 +522,100 @@ public void
test27_preGetOp_commandStringIncludesFamiliesRowsAndFilter() throws
@Test
public void test28_masterOperations_cover() throws Exception {
- RangerAuthorizationCoprocessor cp = spy(new
RangerAuthorizationCoprocessor());
- ObserverContext<MasterCoprocessorEnvironment> mctx =
mock(ObserverContext.class);
- TableDescriptor td = mock(TableDescriptor.class);
- RegionInfo regionInfo = mock(RegionInfo.class);
- TableName tname = TableName.valueOf("t");
- when(td.getTableName()).thenReturn(tname);
- when(regionInfo.getTable()).thenReturn(tname);
- doReturn(null).when(cp).requirePermission(any(), anyString(),
any(byte[].class), any());
- doReturn(null).when(cp).requirePermission(any(), anyString(), any(),
any(), any(), any());
- doReturn(null).when(cp).requireGlobalPermission(any(), anyString(),
anyString(), any());
- cp.preCreateTable(mctx, td, new RegionInfo[0]);
- cp.preDeleteTable(mctx, tname);
- cp.preModifyTable(mctx, tname, td);
- cp.preEnableTable(mctx, tname);
- cp.preDisableTable(mctx, tname);
- cp.preAbortProcedure(mctx, 1L);
- cp.postGetProcedures(mctx);
- cp.preMove(mctx, regionInfo, mock(ServerName.class),
mock(ServerName.class));
- cp.preAssign(mctx, regionInfo);
- cp.preUnassign(mctx, regionInfo, false);
- cp.preRegionOffline(mctx, regionInfo);
- cp.preBalance(mctx, mock(BalanceRequest.class));
- cp.preBalanceSwitch(mctx, true);
- cp.preShutdown(mctx);
- cp.preStopMaster(mctx);
- cp.preSnapshot(mctx, mock(SnapshotDescription.class), td);
- cp.preCloneSnapshot(mctx, mock(SnapshotDescription.class), td);
- cp.preRestoreSnapshot(mctx, mock(SnapshotDescription.class), td);
- cp.preDeleteSnapshot(mctx, mock(SnapshotDescription.class));
- cp.postGetTableDescriptors(mctx, new ArrayList<TableName>(), new
ArrayList<TableDescriptor>(), "rgx");
- cp.postGetTableNames(mctx, new ArrayList<TableDescriptor>(), "rgx");
- cp.preCreateNamespace(mctx, mock(NamespaceDescriptor.class));
- cp.preDeleteNamespace(mctx, "ns");
- cp.preModifyNamespace(mctx, mock(NamespaceDescriptor.class));
- cp.postListNamespaceDescriptors(mctx, new
ArrayList<NamespaceDescriptor>());
- cp.preSetUserQuota(mctx, "u", mock(GlobalQuotaSettings.class));
- cp.preSetUserQuota(mctx, "u", tname, mock(GlobalQuotaSettings.class));
- cp.preSetUserQuota(mctx, "u", "ns", mock(GlobalQuotaSettings.class));
- cp.preSetTableQuota(mctx, tname, mock(GlobalQuotaSettings.class));
- cp.preSetNamespaceQuota(mctx, "ns", mock(GlobalQuotaSettings.class));
- Assertions.assertTrue(true);
+ try {
Review Comment:
These additional changes are unrelated to the JUnit 4 to JUnit 5 migration.
Wouldn’t it be better to handle them separately and keep this pull request
focused solely on the changes required for the JUnit 5 migration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
