pradeepagrawal8184 commented on PR #768: URL: https://github.com/apache/ranger/pull/768#issuecomment-3655057690
> Overall, the changes look good to me. That said, I notice quite a few test modifications that aren't directly tied to the JUnit 4 to JUnit 5 migration. I think these additional test improvements are substantial enough to warrant their own separate PR. I'm not entirely sure how much effort it would take to split them out while keeping the migration changes intact in this PR. Currently I am trying to keep the previous junit 5 version or lower(if needed in any module) and same maven-surefire-plugin version, trying to remove reference of junit 4 as well; Junit 5 migration is required before starting work on jdk17. We might to fix/upgrade the tests again if failing in jdk17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
