pradeepagrawal8184 commented on code in PR #768:
URL: https://github.com/apache/ranger/pull/768#discussion_r2621788908
##########
security-admin/pom.xml:
##########
@@ -827,16 +827,40 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest</artifactId>
+ <version>${hamcrest.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.7.2</version>
Review Comment:
This is intentional and temporary, some of the test code is not compliant
with newer version;
actual junit-jupiter version in the parent pom.xml is 5.10.0 and
maven-surefire-plugin version is 3.0.0-M6;
i have tried to keep the above mentioned version as is; since some of the
current junit test code is not compliant to above mentioned combination. so
have to manage with lower version for now.
Later i am planning to upgrade to 5.11.x and 3.2.x or higher respectively
along with jdk17 support; during that upgrade the junit test code will also be
updated.
##########
security-admin/pom.xml:
##########
@@ -827,16 +827,40 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest</artifactId>
+ <version>${hamcrest.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.7.2</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
- <version>${junit.jupiter.version}</version>
+ <version>5.7.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.7.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.platform</groupId>
+ <artifactId>junit-platform-commons</artifactId>
+ <version>1.7.2</version>
Review Comment:
This library use is temporary; when we move to higher version of
junit-jupiter then it will not be required and shall be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
