lkhsflkhwelhsf!!! crap, crap ... i have to change my vote to -1, there
is a pretty bad bug in the 3.1 release and it's in the 3.0 release as
well =(
Matthew and Iruiz helped me notice this bug ...
In the Weblog.vm file for our 3.0 themes there are calls to
#showWeblogEntryComments($entry) and #showWeblogEntryCommentForm($entry)
which are not valid. the $entry variable is not a valid Roller 3.0
model variable, it refers to a pre 3.0 model variable and therefore
breaks those macro calls if the admin hasn't set
"rendering.legacyModels.enabled=true" in their custom config.
those calls should be ...
#showWeblogEntryComments($model.weblogEntry)
#showWeblogEntryCommentForm($model.weblogEntry)
sadly, I think we need to apply this fix to this release before it goes
out and we should also apply it as a patch to the 3.0 codebase. those
are the 2 instances of that problem which I have noticed because they
were pointed out, but we should do a scan for other places in the theme
files which may be having the same problem.
i really don't know how this wasn't identified before :/
-- Allen
Dave wrote:
Votes to release RC8 as Apache Roller 3.1:
+1 Allen Gilliland
+1 Anil Gangolli
+1 Craig Russell
+1 Jeffrey Blattman
+1 Matt Raible
That gives us four binding Roller PMC votes and thus approves the release.
Our distribution directory is is now in place, so I will move
distribution files in place and put together a graduation / release
announcement before the end of the weekend.
Thanks to all the testers, contributors and commiters.
- Dave
