Please review. I just committed fixes to trunk and branches/roller_3.1
- Dave On 4/21/07, Anil Gangolli <[EMAIL PROTECTED]> wrote:
Dave, I'd like to review; I had fixes prepared for 3.1; There are occurrences in both the HibernateWelbogManagerImpl and HibernateReferrerManagerImpl and I want to make sure we got all of them. Alternately, I can commit. --a. ----- Original Message ----- From: "Dave" <[EMAIL PROTECTED]> To: <dev@roller.apache.org> Sent: Saturday, April 21, 2007 9:20 AM Subject: Re: 3.1 release approved by Roller PMC (was Re: Release Apache Roller 3.1 RC8) > On 4/21/07, Anil Gangolli <[EMAIL PROTECTED]> wrote: >> Allen or Dave, can you look at ROL-1391 and comment on whether you think >> we >> also need to include a fix for that in 3.1 before release? >> >> It just came up. I realized I didn't exercise that path on my crude >> smoke >> test. Has it shown up in your testing? There has been one similar >> complaint about the dayhits calculations throwing ClassCastException in >> e-mail on the users list. > > Yes, I think switching to Number for all sum results makes sense. I > think it's a safe fix and I'm committing it to trunk and the new 3.1 > RC. > > - Dave >
