Hi Olaf,
I think I may have added -Dplayerglobal.version=28.0 as well as setting
PLAYERGLOBAL_VERSION.
However, yes, I am more interested in seeing if the script will run
without any of AIR_HOME/PLAYERGLOBAL_HOME/FLASHPLAYER_DEBUGGER set. So
not only should you remove the checks in ApproveRoyale.xml, but also make
sure those three are not set in the environment. If some of those three
are set, the build will take different paths. I don't have time to dig
into it, but I don’t' think that there should be a
frameworks/libs/Flat.swc if those 3 aren't around.
It could be that the examples still have assumptions about SWF support.
Maybe you can investigate.
The rules for a PMC voter requires testing a release built from the source
package. Only a source package is truly verifiable as being the same as
some other set of files. So, we can't rely on automated builds per-se.
We could rely on the output of the automated builds to generate the source
package, but you'd still have to build that source package. (FWIW, we
don't rely on automated builds for our source packages because we are
trying to use the Maven release process to generate the sources we then
package into the release candidate).
The Approval Script just calls the main build in the Ant build script.
The Ant build script checks for AIR_HOME and then does different things if
it sees it or not. The main build of the SWCs seems to work, but it could
be we have issues in examples.
HTH, and thanks for testing this stuff.
-Alex
On 1/13/18, 1:10 PM, "Olaf Krueger" <m...@olafkrueger.net> wrote:
>Hi
>
>It seems to me that "PLAYERGLOBAL_VERSION" does not work for me for
>whatever
>reason:
>After setting "PLAYERGLOBAL_VERSION=28.0" the script is still complaining
>that "playerglobal.version" should 11.1.
>So I removed "PLAYERGLOBAL_VERSION" and set "PLAYERGLOBAL_HOME" to
>playerglobal.swc version 11.1.
>This works but after a while, a new issue occurs ("Language.swc is not
>found?") [1].
>
>However, if I understand it correctly, you want from me to remove those
>lines [2] from the approval script in order to test if it works without
>the
>AIR/Flash dependencies.
>So I've removed those ENV vars
>(AIR_HOME/PLAYERGLOBAL_HOME/FLASHPLAYER_DEBUGGER) and executes the
>modified
>script.
>It looks good but the build failed cause of an issue with the
>DataBindingExample_Flat [3].
>It complains that "frameworks\libs\Flat.swc is not found"... I took a look
>at the folder and it is there.
>
>I am done for today but two questions are left for now:
>My understanding is that we have automated builds.
>Why do we need to test the build process locally instead of just using an
>automatically created (release candidate) build in order to approve a
>release?
>How does the approval script work without providing those ENV vars?
>
>Thanks,
>Olaf
>
>
>[1]
>Writing file: js\out\org\apache\royale\utils\Language.js
>4.30332045 seconds
>Copying 1 file to
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src
>
>
>\royale-asjs\frameworks\js\libs
>
>main:
>
>copy-swc:
>
>BUILD FAILED
>C:\local\apache-royale\release-process\ApproveRoyale.xml:742: The
>following
>erro
>
>r occurred while executing this line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\build
>
>.xml:643: The following error occurred while executing this line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\frame
>
>works\build.xml:111: The following error occurred while executing this
>line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\frame
>
>works\build.xml:293: The following error occurred while executing this
>line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\frame
>
>works\projects\Language\build.xml:44: Warning: Could not find file
>C:\local\apac
>
>he-royale\release-process\apache-royale-0.9.0-src\royale-asjs\frameworks\p
>roject
>
>s\Language\target\Language.swc to copy.
>
>Total time: 18 minutes 23 seconds
>
>[2]
> <available file="${env.AIR_HOME}"
> type="dir"
> property="AIR_HOME" value="${env.AIR_HOME}" />
>
> <fail message="The AIR_HOME property is not set in environment or
>command-line."
> unless="AIR_HOME"/>
>
> <available file="${env.PLAYERGLOBAL_HOME}"
> type="dir"
> property="PLAYERGLOBAL_HOME" value="${env.PLAYERGLOBAL_HOME}" />
>
> <fail message="The PLAYERGLOBAL_HOME property is not set in
>environment
>or command-line."
> unless="PLAYERGLOBAL_HOME"/>
>
> <available file="${env.FLASHPLAYER_DEBUGGER}"
> type="file"
> property="FLASHPLAYER_DEBUGGER"
>value="${env.FLASHPLAYER_DEBUGGER}"
>/>
>
> <fail message="The FLASHPLAYER_DEBUGGER property is not set in
>environment or command-line."
> unless="FLASHPLAYER_DEBUGGER"/>
>
>
>[3]
>--
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\examp
>les\royale\DataBindingExample_Flat/src/main/royale/DataBindingExample.mxml
>2.045206633 seconds
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\examp
>les\royale\DataBindingExample_Flat\src\main\config\compile-app-config.xml(
>26):
>c ol: 0 unable to open
>'C:\local\apache-royale\release-process\apache-royale-0.9.0
>
>-src\royale-asjs\frameworks\libs\Flat.swc'.
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\examp
>les\royale\DataBindingExample_Flat\src\main\config\compile-app-config.xml
>(line: 26)
>
> </theme>
>
>
>
>BUILD FAILED
>C:\local\apache-royale\release-process\ApproveRoyale.xml:722: The
>following
>erro r occurred while
>executing this line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\build
>.xml:635: The following error occurred while executing this line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\examp
>les\build.xml:85: The following error occurred while executing this line:
>C:\local\apache-royale\release-process\apache-royale-0.9.0-src\royale-asjs
>\examp
>les\build_example.xml:157: mxmlc task failed.
>
>Total time: 23 minutes 29 seconds
>
>
>
>
>--
>Sent from:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-roy
>ale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui%40adobe.com%7
>C4d46426d01cd4bf19e9108d55aca055a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
>C0%7C636514746102961404&sdata=ACRyGbu3z8q%2FcWuzXns4Mn32kepoxQgEpR8vGVBAjI
>g%3D&reserved=0
