Hi Alex, it's ok to remove both. We need to get a first release as soon as possible. People on twitter is ask us for this. So First things first. Thanks
2018-01-18 11:00 GMT+01:00 Alex Harui <aha...@adobe.com.invalid>: > Hi Carlos, > > I don't doubt that MDLExample is referred to often, however it may not be > ok for us to bundle it in Royale releases. The problem is not the images, > it is the bits of CSS and maybe some text content from HTML files that is > the issue. Are you ok with us removing MDLExample and MDLBlogExample in > this release? BTW, both MDLExample and MDLBlogExample seem to run fine > for me on FireFox and Chrome. We will do a "git rm" on those folders and > then fix up pom.xml and build.xml accordingly. If we get a favorable > ruling we can do "git revert" and bring it back. If we have to handle > MDLBlogExample as Category X, then in order to make it look exactly the > same as Google's example, it will never be allowed in the Royale releases, > but we could either make it easy for users to build those examples or > download those examples from some other place on the internet. > > For MDLExample, we have the additional option of tweaking the component > explorer to use different CSS and text. But that will take time so the > thinking is that we should temporarily remove those two examples, get a > release out and then figure out how to make it available to users. > > Thoughts? > -Alex > > On 1/17/18, 4:24 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" > <carlos.rov...@gmail.com on behalf of carlosrov...@apache.org> wrote: > > >Hi, > > > >I think MDLExample is one of the most referred examples out there. I > >couldn't follow all the discussion since I was busy with work and other > >task in this project, but I read that we had some problems with images. We > >can change the images for place holders. If there's some more problem I > >don't know right now. > > > >About MDLBlogExample is unfinished and can be not released. I found some > >blocking problems with CSS compiler when tried to complete. If can be > >removed from release but maintain the code I think it would be ok. > > > >In the end, now we rely heavily in MDL, but we should work forward a > >future > >where we can deprecate that library in favor of our own UI component set > >that could have the same appearance with a theme. > > > >Thanks > > > > > > > > > > > >2018-01-17 10:28 GMT+01:00 Piotr Zarzycki <piotrzarzyck...@gmail.com>: > > > >> Olaf, > >> > >> I'm against even for that. MDLExample should be always in release > >>package. > >> If I understand Alex's idea the things should be fixed in the commit > >>time, > >> so now we have release time. We had that issue for several releases, we > >>can > >> leave with it one more release. > >> > >> Thanks, Piotr > >> > >> > >> 2018-01-17 10:24 GMT+01:00 Olaf Krueger <m...@olafkrueger.net>: > >> > >> > Hi Piotr, > >> > just to make sure you don't get it wrong: > >> > > >> > The idea is to just remove it from the RC2 (So from the first Royale > >> > release > >> > at the end) just in order to have some more time to fix the IP/license > >> > issues and so don't delay the release any longer. > >> > > >> > This does not mean that those examples aren't less important, of > >>course!! > >> > > >> > If I understand Alex correctly, the idea is to have continuous release > >> > cycles, e.g. every 2 or 4 weeks so that we can add the MDL_Example > >>soon > >> > again. > >> > If I can do anything, I'd like to offer some help in order to fix > >>those > >> > issues. > >> > > >> > Is it already clear what we have to do to fix those issues? > >> > If it's not so much effort we maybe could do it right now and keep it > >> with > >> > RC2? > >> > > >> > Just my thoughts, > >> > Olaf > >> > > >> > > >> > > >> > > >> > > >> > > >> > -- > >> > Sent from: > >>https://na01.safelinks.protection.outlook.com/?url=http% > 3A%2F%2Fapache-ro > >>yale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui% > 40adobe.com > >>%7C7cc65c14c3ee495fe57708d55da5537c%7Cfa7b1b5a7b34438794ae > d2c178decee1%7C > >>0%7C0%7C636517887011629087&sdata=q5eKxiKAqUnEvkw8%2BvU0DD% > 2BK%2BKsIk8GxKg > >>pwCS1yzrI%3D&reserved=0 > >> > > >> > >> > >> > >> -- > >> > >> Piotr Zarzycki > >> > >> Patreon: > >>*https://na01.safelinks.protection.outlook.com/?url=https% > 3A%2F%2Fwww.pat > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com > %7C7cc65c14c3ee > >>495fe57708d55da5537c%7Cfa7b1b5a7b34438794aed2c178decee1% > 7C0%7C0%7C6365178 > >>87011629087&sdata=LwRduFSZa%2BNOPd3EJCHZc1Ht7EN5dzgULWvI6G > ffUTQ%3D&reserv > >>ed=0 > >> > >><https://na01.safelinks.protection.outlook.com/?url=https% > 3A%2F%2Fwww.pat > >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com > %7C7cc65c14c3ee > >>495fe57708d55da5537c%7Cfa7b1b5a7b34438794aed2c178decee1% > 7C0%7C0%7C6365178 > >>87011629087&sdata=LwRduFSZa%2BNOPd3EJCHZc1Ht7EN5dzgULWvI6G > ffUTQ%3D&reserv > >>ed=0>* > >> > > > > > > > >-- > >Carlos Rovira > >https://na01.safelinks.protection.outlook.com/?url=http%3A% > 2F%2Fabout.me%2 > >Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7cc65c14c > 3ee495fe57708d5 > >5da5537c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63651 > 7887011629087&s > >data=EHt08YgZdLJoAP4%2Fw%2Bsgw6yBBn3VhnVhK2C4r7%2F1pVw%3D&reserved=0 > > -- > Carlos Rovira > http://about.me/carlosrovira > > >
