I was referring to the js-only build: http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ <http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/>
Like I mentioned, I have not been following the lists as closely as I usually do the last week or two. I certainly did not realize you were doing a major refactor. > On May 10, 2018, at 1:17 PM, Carlos Rovira <[email protected]> wrote: > > Hi Harbs, > > I'm with you that wasn't the right way to do, Was my first huge refactor, > and I think it was aligned with what I talked with you all, special with > Alex, but as well with Peter and you in some emails about that we want to > make a refactor. And for me this was only a part of that, and expect others > like Alex or Peter will be doing the things they have in mind. For this > refactor I only reach the separation goal. > > I think other time I'll be creating a thread, but I think is not the way to > go now. Since the bad is done, we should try to fix instead of going back. > And I think we'll find the problems that we are facing now. > > builds seems ok to me since only #737 and #741 (latest) are failing, so > build was ok for many days after I did the refactor. So is ANT what is > failing for you localy? if so, the way to fix this is try to fix ANT build > > > > 2018-05-10 11:52 GMT+02:00 Harbs <[email protected] > <mailto:[email protected]>>: > >>> On May 10, 2018, at 12:45 PM, Carlos Rovira <[email protected]> >> wrote: >> >> >>> sorry that you are frustrated. But any change we'll do to refactor >> things, >>> will have the same effect in your application code base >> >> If there’s a good reason for a refactor, then I agree with you. You have >> yet to convince us that is the case. >> >> Please let’s focus on your reasons for doing so. I simply don’t understand >> why you think it’s important. >> >> Whether you are right or wrong, making such major changes to the develop >> branch without first building consensus that it’s the right thing to do is >> the wrong way to go about it. >> >>> Right now, Maven build is green in all parts (frameworks, projects, >> themes, >>> examples....) >> >> The Azure build has been failing for 4 days (I believe since you did your >> refactor work): >> http://apacheroyaleci.westus2.cloudapp.azure.com:8080/ < >> http://apacheroyaleci.westus2.cloudapp.azure.com:8080/ >> <http://apacheroyaleci.westus2.cloudapp.azure.com:8080/>> >> >> >> Thanks, >> Harbs >> >> > > > -- > Carlos Rovira > http://about.me/carlosrovira <http://about.me/carlosrovira>
