----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129365 -----------------------------------------------------------
bin/grid (line 130) <https://reviews.apache.org/r/46303/#comment192804> Ah.. Can you add the wait_for_service line here for zookeeper? wait_for_service "zookeeper" 2181 bin/grid (line 140) <https://reviews.apache.org/r/46303/#comment192805> Can you add the wait_for_service line here for RM and NM? wait_for_service "resourcemanager" 8032 wait_for_service "nodemanager" 8042 - Navina Ramesh On April 18, 2016, 3:29 p.m., Vishal Kuo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46303/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 3:29 p.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > To prevent kafka dependent services and unit tests to fail intermittently > after bootstrap, a wait_kafka function has been added > > > Diffs > ----- > > bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 > > Diff: https://reviews.apache.org/r/46303/diff/ > > > Testing > ------- > > * Tested normal bootstrap procedure works with additional wait added for kafka > * Tested that timeout occurs if Kafka takes too long to start > > > Thanks, > > Vishal Kuo > >