> On April 19, 2016, 6:23 p.m., Boris Shkolnik wrote: > > bin/grid, line 165 > > <https://reviews.apache.org/r/46303/diff/3/?file=1348609#file1348609line165> > > > > just wondering - why -w 2? -w 1 should work as well? If the port is not > > open it will return right away, will it?
Sorry about that, the 2 was just arbitrary. 1 makes more sense. > On April 19, 2016, 6:23 p.m., Boris Shkolnik wrote: > > bin/grid, line 41 > > <https://reviews.apache.org/r/46303/diff/3/?file=1348609#file1348609line41> > > > > can you please change the name to specify the time units? (.._SEC). It > > makes it clearer. All changes made - Vishal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129584 ----------------------------------------------------------- On April 19, 2016, 7:39 p.m., Vishal Kuo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46303/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 7:39 p.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > To prevent kafka dependent services and unit tests to fail intermittently > after bootstrap, a wait_kafka function has been added > > > Diffs > ----- > > bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 > > Diff: https://reviews.apache.org/r/46303/diff/ > > > Testing > ------- > > * Tested normal bootstrap procedure works with additional wait added for kafka > * Tested that timeout occurs if Kafka takes too long to start > > > Thanks, > > Vishal Kuo > >
