----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129584 -----------------------------------------------------------
bin/grid (line 41) <https://reviews.apache.org/r/46303/#comment193018> can you please change the name to specify the time units? (.._SEC). It makes it clearer. bin/grid (line 129) <https://reviews.apache.org/r/46303/#comment193014> nit. please remove the space. bin/grid (line 130) <https://reviews.apache.org/r/46303/#comment193020> Could you please use GLOBAL_VAR for the port numbers and declare them upfront (in case someone ever uses it for different purpose). bin/grid (line 161) <https://reviews.apache.org/r/46303/#comment193017> please make the variables local(to avoid overwriting a global ones). bin/grid (line 165) <https://reviews.apache.org/r/46303/#comment193031> just wondering - why -w 2? -w 1 should work as well? If the port is not open it will return right away, will it? - Boris Shkolnik On April 18, 2016, 6:28 p.m., Vishal Kuo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46303/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 6:28 p.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > To prevent kafka dependent services and unit tests to fail intermittently > after bootstrap, a wait_kafka function has been added > > > Diffs > ----- > > bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 > > Diff: https://reviews.apache.org/r/46303/diff/ > > > Testing > ------- > > * Tested normal bootstrap procedure works with additional wait added for kafka > * Tested that timeout occurs if Kafka takes too long to start > > > Thanks, > > Vishal Kuo > >
